ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
313 stars 25 forks source link

fix(patch): Fix issues with broken build when visionOS is unknown #261

Closed hassila closed 1 month ago

hassila commented 1 month ago

Description

Fix https://github.com/ordo-one/package-benchmark/issues/256

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.32%. Comparing base (a214635) to head (1ba00d9).

Files Patch % Lines
Sources/Benchmark/BenchmarkClock.swift 50.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #261 +/- ## ======================================= Coverage 65.32% 65.32% ======================================= Files 33 33 Lines 3610 3610 ======================================= Hits 2358 2358 Misses 1252 1252 ``` | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/BenchmarkClock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?src=pr&el=tree&filepath=Sources%2FBenchmark%2FBenchmarkClock.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrQ2xvY2suc3dpZnQ=) | `35.48% <50.00%> (ø)` | | | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/BenchmarkClock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?src=pr&el=tree&filepath=Sources%2FBenchmark%2FBenchmarkClock.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrQ2xvY2suc3dpZnQ=) | `35.48% <50.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [a214635...1ba00d9](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/261?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 1 month ago

Pull request had an unknown failure Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-08-13T10:35:35+00:00