search

ordovice / batocera-switch

Extends Batocera and adds switch emulation
149 stars 32 forks source link

remove forced version number #273

Closed toccata10 closed 5 months ago

toccata10 commented 5 months ago

As this version (42) is too low, if the user sets the upscaling to "FSR", it will go back to "Bilinear" because I suppose that "FSR" was not supported in old versions of the config file.

I don't think there's an advantage in keeping an old version number which erases what the user sets in ryujinx. But maybe there are some specific cases ? Or maybe, we don't need this anymore.

uureel commented 5 months ago

can you test this? 

        if system.config['emulator'] == 'ryujinx-avalonia':
            if ryu_version >= 1215:
                data['version'] = 49
            elif ryu_version >= 924:
                data['version'] = 47
            else:
                data['version'] = 42
        else:
            if ryu_version >= 1215:
                data['version'] = 49
            elif ryu_version >= 924:
                data['version'] = 47
            elif ryu_version > 382:
                data['version'] = 42
            else:
                data['version'] = 40
toccata10 commented 5 months ago

Seems good to me: with the latest version, it now keeps my FSR choice for upscaling.