search

ordzaar / ord-connect

Bitcoin Ordinal & Inscription aware wallet connect kit (React)
71 stars 13 forks source link

SSR rendering throws ReferenceError: localStorage is not defined #282

Closed poocart closed 2 months ago

poocart commented 5 months ago

When web uses renders static content over SSR (i.e. on Next.js), it throws ReferenceError: localStorage is not defined error when trying to read from local storage within @ordzaar/ord-connect code.

github-actions[bot] commented 5 months ago

@poocart: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [ordzaar](https://github.com/ordzaar) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/ordzaar/ord-connect/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 5 months ago

@poocart: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [ordzaar](https://github.com/ordzaar) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/ordzaar/ord-connect/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 5 months ago

@poocart: Thanks for opening an issue, an appropriate priority will be added soon.

The priority labels can be added by foundation members by writing /priority [type] in a comment.

Details I am a bot created to help the [ordzaar](https://github.com/ordzaar) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/ordzaar/ord-connect/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
Nanosync commented 2 months ago

Fixed in #289