search

ore- / Graphics

Graphics settings plugin for AIGirl
GNU General Public License v3.0
23 stars 18 forks source link

Post Processing is still kinda weird in Character Creation. #34

Closed hooh-hooah closed 4 years ago

hooh-hooah commented 4 years ago

It does loads correctly but i think character creation scene actually using more than 2 post processing before clicking post processing tab.

ore- commented 4 years ago

to debug, click the Show Advanced Settings toggle, and you will see all (2) the pp volumes used. Studio also has 2 but the other one has 0 weight by default. Maker has both with weight == 1 by default

hooh-hooah commented 4 years ago

oooh I get it

hooh-hooah commented 4 years ago

ooh apparently 2d volume is just for 2d confirm ui... but it's only being used in main game and IBL only supports that in Maker.... Maybe it's good to set 2D Volume to 0 by default.

ore- commented 4 years ago

we could do. I would like to avoid overriding any default settings, and allow for any changes to happen through menus we expose. we could provide a sane and more appropriate default preset but no settings should be overridden in code. I think the saving code should be generic enough to all available pp volumes. if this is just too much work, we can make it a medium term goal but my fear is that it may change the save settings a lot and make previous scene data incompatible.

hooh-hooah commented 4 years ago

we could do. I would like to avoid overriding any default settings, and allow for any changes to happen through menus we expose.

Me too but there is no reason to keep more than 2 post processing volumes. This plugin is designed for Maker and Studio atm. I know there is still some people still prefers default ILLUSION look but...

we could provide a sane and more appropriate default preset but no settings should be overridden in code. I think the saving code should be generic enough to all available pp volumes. if this is just too much work, we can make it a medium term goal As you said, we can keep Original Feeling as built-in preset. There is already few ideas for quick preset:

  • Default ILLUSION Look
  • Fast Mode (Turn off all PP, Scale down everything)
  • Some Well Made Presets

but my fear is that it may change the save settings a lot and make previous scene data incompatible.

Yes, that is my fear too but that's why we have #9. We can work on it after releasing first version with save feature

ore- commented 4 years ago

sure, let's go with your 3 bullets.