search

oreillymedia / HTMLBook

Let's write books in HTML!
http://oreillymedia.github.io/HTMLBook
MIT License
650 stars 100 forks source link

Adding the Author Bio to the TOC #243

Closed nadamsoreilly closed 3 years ago

nadamsoreilly commented 3 years ago

This PR updates the logic of the XSL that generates the TOC to include the author bio in the TOC. This is done by changing the line excluding colophons to only exclude colophons if they do not contain the class abouttheauthor (this is standard for our boilerplate).

It also updates our XSpec testing suite to match the new behavior.

This request comes from Kristen and is based on author complaints of how the Author Bio displays on the UCV on the Platform.

https://intranet.oreilly.com/jira/browse/TOOLSREQ-7334

Re-requesting a review because I added the XSpec commit and the time elapsed since the earlier PR.

nadamsoreilly commented 3 years ago

Just to double-check, should this PR be based on master or stage?

The functional part of the PR has been QAed on Staging (looks like I forgot to tag you on that PR). I added the xspec test for this one, but since it's a test only change I thought it could go straight to master.