search

oreillymedia / asciidoctor-htmlbook

Templates for the htmlbook backend for Asciidoctor
45 stars 15 forks source link

Master #103

Closed eshellman closed 3 years ago

eshellman commented 8 years ago

this fixes toc's including sections failing to to convert properly- see https://github.com/GITenberg/Don-Quixote_996/releases/tag/0.0.3

Also silences warnings about

sandersk commented 8 years ago

Thanks very much for the PR, @eshellman. Would you mind providing a bit more context on how you're using the asciidoctor-htmlbook templates at GITenberg--i.e., example source files and the commands you're running on them to produce output--so I can reproduce the issue and confirm the fixes?

eshellman commented 8 years ago

sure, look at https://github.com/GITenberg/Adventures-of-Huckleberry-Finn_76/blob/master/.travis.yml and https://github.com/GITenberg/Don-Quixote_996/blob/master/.travis.yml

Look at the history of https://github.com/gitenberg-dev/asciidoctor-htmlbook to see where these changes are coming from. Pushing some of our work upstream would facilitate ongoing merges.

ruralocity commented 3 years ago

Hi, thank you for this pull request. I’m sorry that it’s taken so long to get back to you about it. Because of the length of time that’s passed since O’Reilly has actively reviewed pull requests to this project from outside contributors, and because of the context lost in that time, we’re closing all stale pull requests.

If you still feel we should consider this pull request, please feel free to reopen, and we’ll review it in a timely manner. Thanks again!