orels1 / Red-Portal

A cog-listing project for Red-DiscordBot
http://cogs.red
MIT License
10 stars 1 forks source link

New parser #44

Closed orels1 closed 6 years ago

orels1 commented 7 years ago

New parser concept

Admins and staff will still be able to trigger the parser manually (the system-wide repo-parse is only available to admins), but the main way to update will be to trigger on significant repo updates

Goals achieved:

Cons:

Internal structure

palmtree5 commented 7 years ago

"Significant repo updates":

Do I have this right or am I missing something?

orels1 commented 7 years ago

Yes, although if the New Cog doesn't have an info.json I won't add it.

Kowlin commented 7 years ago

Shit I did it again! I looked at the issue and replied 2 days later! It looks good to me, but we can probably resolve the last con, I actually don't think its a con, the only reason we add those repo's is on request. However you do open a path to a giant spam of repo's build as Red extensions or not, so I do think that we need some basic verification steps. Let a staff member review the repo? How will we keep up to date about this? Webhook ;)

orels1 commented 7 years ago

Well, I mean, there is a basic review process - if the repo contains info.json, at least one cog and that cog also has an info.json, I think that's enough, 'cause currently that's what I check before adding to the "unapproved" category

About keeping up-to-date, I will create a channel on my own server with something like "cogs.red changes" to spam events like "repo added" and "repo type changed".

This seems to be good enough

Kowlin commented 7 years ago

Sounds fair, now if I can get a invite to this mythical server, we will be set ;)