search

orels1 / orels-Unity-Shaders

A collection of practical Unity shaders for your next project
https://shaders.orels.sh
Other
168 stars 13 forks source link

Makes "Hide from Main View" options match the behavior described in the docs. #68

Open CheesecakeCG opened 1 month ago

CheesecakeCG commented 1 month ago

This would break compatibility with materials using current version of the shader.

The "Hide from Main View" options seem to just hide the geometry completely (for cameras and mirrors too) rather than hiding only in the main view. The docs & property labels imply these work the same way as the other 4 options for just the mirror or camera views.

orels1 commented 1 month ago

Hey, thanks for the PR. That was definitely not intentional. I was under the impression that isVR() check I had only pass for main view

CheesecakeCG commented 1 month ago

I didn't test in VR before I submitted this (and forgot to hit send when I wrote this reply a week ago 😅), the issue still happens in VR. :/ This does fix it in desktop though.

Was this working in Unity 2019 or 2022.3.6f1? Maybe something's broken with the VR check?