search

oremanj / python-netfilterqueue

Python bindings for libnetfilter_queue
MIT License
248 stars 96 forks source link

#define PyString_FromStringAndSize -> PyUnicode_FromStringAndSize #32

Closed adisbladis closed 5 years ago

adisbladis commented 7 years ago

In Opensnitch we had some Gentoo users with issues related to this (https://github.com/evilsocket/opensnitch/issues/69).

mattfox commented 6 years ago

Thanks for the contribution and my apologies for ignoring it. Updating netfilterqueue.c is not ideal because it's the generated output from Cython. The .c file is only included in the source so it can be used without Cython.

If this PR was accepted as-is, it would be reverted the next time someone submitted a change to the .pyx. Unfortunately it's been a while since I've done any Cython and I'm not sure off the top of my head what Cython results in a #define in the C file. Perhaps a something related to a cdef extern in the .pxd?

adisbladis commented 5 years ago

I'm not using this software any more and am therefore not interested in pushing this forward.