search

orendain / DemeoMods

Mods for the game of Demeo, as well as the Demeo modding framework, HouseRules.
MIT License
42 stars 11 forks source link

Use consistent namespacing for HouseRules comonents. #502

Closed orendain closed 1 year ago

orendain commented 1 year ago

The HouseRules Configuration mod lives under namespace HouseRules.Configuration, and the HouseRules Essentials mod lives under namespace HouseRules.Essentials. HouseRules Core, however, had the plain root namespace HouseRules (rather than HouseRules.Core, which would be consistent). Additionally, namespaces and folder structure did not match (e.g., HouseRules.Essential namespace vs HouseRules_Eseential folder).

The convention is to use namespaces that match the folder structure, which this PR does.

Full disclosure: Some consider the standard of having namespaces match the folder structure an anti-pattern.

orendain commented 1 year ago

This commit builds but also somehow says there are conflicts that must be resolved using the command line?

Looks like given the changes that were just merged, GitHub wasn't able to automatically resolve how to update this branch with the latest main changes. Manually updated this branch and should be good to review again.