App reports wrong speed

[orenyodfat]

Looking at the code ...does the following scenario is possible?:

• App detect a GPS location change of 30 meters.
• It calls the readsensors func.
• readsensor func call readWifi. -readWifi start a WiFi scan . The scan takes around 10 seconds and onFinishScan it calls readGPSData. -Few milisecond after that..due to a "real" location change of 30 meters there is a call again to readsensors which scan the WiFi immediately ..and a call to readGPSData done with a very similar time stamp as the previous one. If the scan take more than 10 seconds there can also consecutive calls to scan during scan.

I would suggest:

1. Add a flag on the readWiFi so we will be sure there are no WiFi scan calls during scan.
2. Log that case if it happened.
3. Take a time stamp at onFinishScan and check that there is more than 10 seconds pass between the previous call at readWiFi entrance.

A question: Does the Utils.Wait(2000) call at the readWiFi (for the case there is no WiFi) is only for the WiFi thread?

[orenyodfat]

Current fix is not complete because the app ignore location changes and loos locations. I am suspecting the 2 seconds wait. If the original state of the WiFi was enable there is no wait of 2 seconds. If the original state of the WiFi was disable so there is a sequential wait of 2 seconds each scan ...why?

I suggest the following to remove the 2 seconds wait. 1.We do not need to turn WiFi on and Off continually...any way when we are moving it most of the time on. 2.At lbmservice.java line 987 -- (when there is a more than 10 KMH movement) enable wifi if it was not enable before.

3. If you need to wait till it turn on ...so instead waiting 2000 mili ,check the status each 200 mili (10 times in a loop).
4. Turn WiFi off on the 5 min gps timer finish (onFinish).