Move report-specific functionality into Report class

oreoshake / hackerone-client

An unofficial wrapper for the HackerOne API

https://api.hackerone.com/docs/v1

MIT License

55 stars 27 forks source link

Move report-specific functionality into Report class #20

Closed oreoshake closed 7 years ago

oreoshake commented 7 years ago

state_change, add_comment, triage, add_report_reference are all specific to reports yet live in the hodge podge HackerOne::Client class.

This is fine when the library is tiny and with few developers, but it can get out of hand quickly.

There's probably a few opportunities to DRY up the code too.

esjee commented 7 years ago

Wouldn't moving this functionality somewhere else cause a breaking change? If so, is that acceptable?

oreoshake commented 7 years ago

Maybe we can get away with delegators and deprecation statements but semver does allow for unstable APIs until 1.0.

esjee commented 7 years ago

I can look into this once #22 has been merged. Once the helpers introduced in that PR are available, I think resolving this task would be a bit easier.