search

oreoshake / hackerone-client

An unofficial wrapper for the HackerOne API
https://api.hackerone.com/docs/v1
MIT License
55 stars 27 forks source link

Make activities pagination consistent with other endpoints #40

Closed martijnrusschen closed 4 years ago

martijnrusschen commented 5 years ago

In an effort to make our pagination consistent across our API endpoints, we found that this endpoint is using a different way of paginating. We're changing the parameter from first to page[size] and will be introducing links to a potential next page in the response.

As Github has been the only user of this endpoint, we're updating this client to be compatible with the new pagination. All other endpoints will remain the same.

martijnrusschen commented 5 years ago

Build is failing as the changes haven't been rolled out yet. Will update the tests once we have this ready.

oreoshake commented 5 years ago

/cc @anglinb @brentjo

martijnrusschen commented 5 years ago

Updated the specs as we rolled out the API change. Should be good to go after merging this. Also added some additional activity classes based on the API results I got. There are more to add, but didn't encounter them during testing.