oreoshake / hackerone-client

An unofficial wrapper for the HackerOne API
https://api.hackerone.com/docs/v1
MIT License
55 stars 27 forks source link

Lock a report #59

Closed rzhade3 closed 4 years ago

rzhade3 commented 4 years ago

This PR adds the ability to lock a report, and fixes some imports that were screwing up my tests.

NOTE: There's some interesting behavior with the H1 API, where if you try to lock a report that isn't closed, it'll return a 403 error (which is pretty misleading). ~It should be fairly easy to prevent this on the client Gem which would prevent users from getting this misleading error response. This would work by asserting that the report is in a given state before allowing the API request to go out, however would require us to keep track of the "closed" states that H1 uses. Wouldn't be too much work to add, but just wanted to ask before I implement that.~