search

oreporan / wePlayMin

WePlay - the social football managing app
0 stars 1 forks source link

add profilePicURL field to User Object #44

Open oreporan opened 8 years ago

oreporan commented 8 years ago

@Yahavw - I think you are right, it makes more sense to just give the clientside a URL to send, the client shouldn't really know/care how every user is authenticated (fb/google/custom).

I added this field to the user object -

profilePicURL : {type : String}

oreporan commented 8 years ago

As of now there is still no way to upload a profile picture, but FB users will have the path to their profile pictures automatically.

When I open another endpoint for users/profilePic for adding/getting a profile pic, then i will close this issue

oreporan commented 8 years ago

I'm not sure how to do it, maybe it makes more sense to add the profilePic image itself to the user object. Because if I just give a URL then for each user you need to make 2 requests to the DB. But then we have the FB/Google users, should I get the image for them also? or leave the client to do this?

mmm..