oresat / CANopen-monitor

An NCurses-based TUI application for tracking activity over the CAN bus and decoding messages with provided EDS/OD files.
https://canopen-monitor.readthedocs.io/
GNU General Public License v3.0
25 stars 6 forks source link

DCF support #53

Closed ryanpdx closed 3 years ago

ryanpdx commented 3 years ago

CANopen monitor should support DCF files too.

ryanpdx commented 3 years ago

Example dcf: generic_OD.txt Note: to attach this to a GitHub comment it is a .txt file. Noramally it would be a .dcf file

Boneill3 commented 3 years ago

The only issue I had when parsing this file was that there is an empty line as the last line in the file, besides that the parser seems to be working just as well as with the eds file.

ryanpdx commented 3 years ago

Are you getting node id from index 0x2101?

ryanpdx commented 3 years ago

That index is added by CANopenNode by default and is not apart of the CANopen specs.

ryanpdx commented 3 years ago

I realize i forgot to set the node id and device name in in that dcf. It is set in generic_OD.txt

Boneill3 commented 3 years ago

I noticed that nodeid here is 10, should that be 0x10? Or should decimal or hex be acceptable values?

ryanpdx commented 3 years ago

I know that one is decimal, i don't know if it can be hex.

ryanpdx commented 3 years ago

From eds/dcf specs: "Integer numbers shall be written as decimal numbers, hexadecimal numbers or octal numbers. Hexadecimal numbers are preceded by 0x. Octal numbers shall start with a leading 0 (not followed by x)."