search

oresat / CANopen-monitor

An NCurses-based TUI application for tracking activity over the CAN bus and decoding messages with provided EDS/OD files.
https://canopen-monitor.readthedocs.io/
GNU General Public License v3.0
25 stars 6 forks source link

Fix SDO name parsing #85

Closed mennogrow closed 5 months ago

mennogrow commented 1 year ago

When parsing received SDO messages, the mapping to the OD was incorrect. The CANopen frames are little endian but the index field was processed as big endian resulting in the wrong key. By reversing the index_bytes we set the correct endian.

dmitri-mcguckin commented 1 year ago

Looks like this change broke some one of our unit tests which means the old way may have been expected behavior.

I can look into this when I get time, though if you'd like to as well and get python3 -m unittest tests/spec_*.py to pass locally, I can re-assess it and potentially merge in faster.

mennogrow commented 1 year ago

I will try to look into this in the coming week.

dmitri-mcguckin commented 5 months ago

CANOpen Monitor is no longer being supported by Oresat.

Any remaining issues will be closed and the repo will be archived.