Closed venomboss985 closed 5 months ago
In general it's good to follow the directory-style branch naming schemes.
There's many ways to do it but they all generally resemble:
fix/dcf-parsing
for bug fixesfeat/some-feature
for new featuresNo need to update this branch name- just for future reference.
In the module init file, please bump version to 4.1.1
In all- I'm not sure if this fixes #86 just yet.
I tested this branch on the MDC last night and was unable to get the DCF messages, so there still appears to be an issue with the passing of the configs. (Same error as before: couldn't find associated DCF config)
I think we ought to consider adding the switch to
configparser
for our DCF parsing in this PR.
For sure, I'll do some testing today.
This commit should fix the DeviceCommissioning
spelling issue in the DCF file generated from oresat-configs
. It now uses either DeviceCommissioning
or DeviceComissioning
, whichever is present.
CANOpen Monitor is no longer being supported by Oresat.
Any remaining issues will be closed and the repo will be archived.
This fix is primarily fixing a bug where a new DCF file generated for Oresat 0.5 will not parse properly and crash on startup. The PR addresses issue #86 and should be good to close afterwards.
Something to note, the bug in issue #87 is also causing CM to crash, so as a temporary fix, you will need to change every location where it says
[DeviceComissioning]
to[DeviceCommissioning]
(adding an 'm') in your DCF. When I continue development, I'll use this current branch to fix issue #87 as well.