search

oresat / oresat-firmware

OreSat firmware based on ChibiOS for M0 and M4 microcontrollers
GNU General Public License v3.0
36 stars 13 forks source link

Dev chad add l4 cpp template #11

Closed chroco closed 5 years ago

chroco commented 5 years ago

Ok here is my revised pull request for a ChibiOS C++ template

heliochronix commented 5 years ago

Initially, it seems like it will probably work. However, I'd like to merge in the CAN development branch and base it on that if possible because there's been some underlying changes. I've attempted to prepare the candev branch for use in C++ programs by having the headers check directly for __cplusplus and if defined does extern "C". This should eliminate the need for you to manually do it when including the headers, keeping the code clean. Let me try to merge your branch into candev and see if there's anything that needs doing to ensure it will merge cleaning once candev gets pulled into master.

heliochronix commented 5 years ago

Okay, so I incorporated your branch into candev and made it consistent with the new system that will be put into place. There were also some slight coding style updates I made to be consistent with the coding styles used everywhere else in the project. If you begin a new project based off app_template_cpp, would you be willing to branch off candev and develop from there? That way, when candev gets merged into master there will be very little effort required to also add your new code, as it should just be a merge.

heliochronix commented 5 years ago

Note: The new stuff is nearly ready. I just need to clean up the object dictionary stuff because it has a lot of example entries we don't actually need and they're taking up space. I just need to keep it consistent with the specification is all.