search

oresat / oresat-firmware

OreSat firmware based on ChibiOS for M0 and M4 microcontrollers
GNU General Public License v3.0
36 stars 13 forks source link

Diode Test Card #96

Closed chroco closed 4 months ago

chroco commented 5 months ago

Development code for the diode test card

ThirteenFish commented 4 months ago

The PR is labeled as being for the diode card, but I also see things which could be considered outside the scope - an unused CANTALK_V0 board, a new app_nucleo and extensive changes to app_protocard. Were these intended to be added?

It's OK if they're intended but in general it's a good idea to keep the scope of a PR focused on the main task. The more focused a PR is, the easier it is to review and accept.

chroco commented 4 months ago

This PR was rushed and has a lot of changes that shouldn't go to master. I think this PR should just die. There is a much better (more focused) branch to do this with.

chroco commented 4 months ago

Closing this PR