search

orf / simple

Simple is a clone of Obtvse written in Python running on Flask.
MIT License
505 stars 280 forks source link

Settings variable "BLOG_URL" is only used in index.xml #35

Open hellerbarde opened 11 years ago

hellerbarde commented 11 years ago

Somehow the variable "BLOG_URL" is not being used anymore except in the index.xml and I'm not sure it's even neede there nor am I sure that it's being properly used.

@orf can you take a quick look at it?

orf commented 11 years ago

I think its needed, there has to be a way for flask to know the base URL of your app. I don't really use Flask so I don't know though.

hellerbarde commented 11 years ago

It's in fact a problem, because we allow/encourage users to put in "/blog" or "/" as the BLOG_URL variable and as far as i can tell, this variable is put in the rss xml directly as a link to the blog. Which is only true if you actually click on the link from that domain. if you're in google reader or another rss reader it'll just fail. On your blog specifically, you must have literally put in "http://yourdomain.tld" to make your RSS not be broken. can you confirm this? I'll fix it tomorrow.

hellerbarde commented 11 years ago

this is more in depth than expected...