r9 - Vehicle actor sheets + a minor typo correction

miqued commented 1 year ago

This request is to add an actor sheet for land vehicles and one for water vehicles, add localizations for their attributes, and changed "companium" to "companion" in the readme.

miqued commented 1 year ago

opensheets selectionmenu

orffen commented 1 year ago

Thanks for submitting - I will review this one, but it may take me a while. It's a busy time of year 😄

orffen commented 1 year ago

At a glance, this one looks pretty good. I am about to release r9 to fix a bug #41 and need a little more time to review this one (and then clean up for the r10 release).

Sorry for the delays on this one, it is on my list. I'm not sure I've ever used the vehicle rules, so I'll need to brush up on those as well :)

orffen commented 12 months ago

I've taken a look at this one but I've got a few thoughts about how I might want to implement this a little differently.

Are you using these sheets in your game already @miqued? Would love to hear how you're using them at the moment - are you doing much with them beyond tracking information?

I'm not sure we need 2 separate sheets; I think the main thing to track is Movement, Hardness and HP (these are the only mechanical stats particularly relevant and are common cross both vehicle types)
They should be defined as resources inside the system so that on the map we can get status bars for vehicle tokens
I think a Siege Engine sheet would be a good idea as well, and then the natural extension of that is a Stronghold sheet; that allows for land battles

What do you think?

miqued commented 12 months ago

Vehicles haven't really come up in the game I run (which is why I erroneously put hardness as a 2-part value, thinking it could somehow be reduced. Oops), but I also had more in mind for a future version of the sheets. The plan I had, especially for naval vessels but other vehicles too, was to have a sheet that can be used to manage all of a vehicle's cargo, passengers, defenses, etc. However, no work beyond what is in this PR has been done on the sheets, so "where do we go from here?" will be new ground any direction.

It did start as a single sheet type "Vehicle" as I worked on it locally, but I wanted to present the information exactly as-is in the books, and land vehicles have weight while water vehicles have a miles/day stat. They could be unified, but that at least is why they aren't in what I have.
I agree with defining the stats in the system. I didn't know there was more to do with that. I haven't done much with vehicle tokens yet, so it never occurred to me.
I ran into whether to have a separate Siege Engine sheet while working on a module for the Equipment Emporium. I just added them as weapons for that, since, without a "monster", the stronghold or fortification, an actor-type sheet would be all alone with nothing to interact with. I hadn't thought about adding a Stronghold sheet, but both of those sheets would work great together.

orffen commented 12 months ago

@miqued I've added my thoughts and notes in the individual issues below for each sheet. Would love to get your thoughts in there as well if you have time and inclination 🙂

orffen commented 11 months ago

Pretty pleased with this sheet - I'll close this pull request. Thanks so much for your work on this @miqued!

This will be included in r13. Also: 😁

orffen / basicfantasyrpg

r9 - Vehicle actor sheets + a minor typo correction #39