search

orffen / basicfantasyrpg

The Basic Fantasy RPG system for FoundryVTT!
Other
13 stars 12 forks source link

Fix stat bonuses for attacks #42

Closed totallybanjaxed closed 1 year ago

totallybanjaxed commented 1 year ago

suggested fix for Issue #41

feel free to do it differently / better.

orffen commented 1 year ago

Hmm, this is interesting.

The line data[k] = foundry.utils.deepClone(v); previously cloned those values to those helper attributes. I'll need to take a closer look at why it's not working anymore - but my preferred fix is to fix that deepClone so that the values can again be used as @str etc.

orffen commented 1 year ago

Found the issue - I was checking for this.system.type - v10 changed this, it should have been just this.type. Fixed that issue, don't need this pull request.

However, thank you for looking into it!