search

orffen / basicfantasyrpg

The Basic Fantasy RPG system for FoundryVTT!
Other
13 stars 12 forks source link

R14 candidate #72

Closed DC23 closed 3 weeks ago

DC23 commented 3 weeks ago

With the addition of the pending PR for the French localization, this PR should be everything you need for #67 I've tested in Foundry 11.315 and 12.331. Everything appears to be working correctly now, with no deprecation warnings or errors in either major Foundry version.

As you can see from the commits, I've bundled #71 and #64 into this PR. #71 was the biggest challenge, but the fix was simple enough once the problem was understood, and the understanding will be helpful with the eventual move to the new class-based data models.

orffen commented 3 weeks ago

Looks great! Thanks again for your work on this.