search

org-arl / InteractiveViz.jl

Interactive visualization tools for Julia
MIT License
109 stars 6 forks source link

Depend on AbstractPlotting #7

Closed SimonDanisch closed 4 years ago

SimonDanisch commented 4 years ago

First of all, nice package!! :) Just wanted to drop in, and say, that you should rather depend on AbstractPlotting, instead of Makie: https://github.com/org-arl/InteractiveViz.jl/blob/80fd2a5216c9ebd454c39bb54c3284fcba233dd7/Project.toml#L8 using Makie is identical to using AbstractPlotting, GLMakie. But if you just depend on AbstractPlotting, your users can easily switch out backends, and e.g. display those plots in the web or save it to a pdf with CairoMakie ;) If you want to have GLMakie as a default backend readily available for your user, depending on Makie.jl is fine, since it's still possible for the user to switch backends ;) They just always need to compile GLMakie as well, even when not using it!

mchitre commented 4 years ago

Thanks for the feedback. Will update.

mchitre commented 4 years ago

Done