Closed ymtoo closed 1 year ago
For partition
, before the changes:
julia> pad_x
7-element PaddedView(0, OffsetArray(::Vector{Int64}, 1:5), (0:6,)) with eltype Int64 with indices 0:6:
0
1
2
3
4
5
0
julia> ps = SignalAnalysis.partition(signal(pad_x, 1), 2);
julia> for p ∈ ps
println(p)
end
[1, 2]
[3, 4]
[5, 0]
[0]
After the changes:
julia> for p ∈ ps
println(p)
end
[0, 1]
[2, 3]
[4, 5]
[0]
Base: 73.44% // Head: 74.44% // Increases project coverage by +1.00%
:tada:
Coverage data is based on head (
adf9bfa
) compared to base (0b9e9ef
). Patch coverage: 88.88% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ymtoo is this ready to be reviewed and merged?
@mchitre yes
For
padded
, before the changes:After the changes, padded of a vector or matrix with custom indices works.