search

org-arl / SignalAnalysis.jl

Signal analysis toolbox for Julia
MIT License
42 stars 11 forks source link

Views and padded views over a SampleBuf lose metadata #4

Closed mchitre closed 4 years ago

mchitre commented 4 years ago

@view and padded() on a SampleBuf do not return a SampleBuf and so effectively lose metadata. We should re-wrap those, but that can only be done if SampleBuf accepts AbstractArrays, which it currently doesn't.

Will need to raise a PR and wait for it to be merged before this can be fixed.

mchitre commented 4 years ago

Once this is done, we should use @view in iplot() at iplot.jl:30

mchitre commented 4 years ago

@view now works. iplot comment may not longer be relevant.