scipy window functions produce different results than numpy window functions

org-arl / arlpy

ARL Python Tools

BSD 3-Clause "New" or "Revised" License

119 stars 37 forks source link

scipy window functions produce different results than numpy window functions #14

Closed mchitre closed 5 years ago

mchitre commented 5 years ago

scipy.signal.get_window('hanning', 64) does not work as well as np.hanning(64); same for other windows; need any fix in arlpy?

saimahmed commented 5 years ago

They don't work when used as a filter in frequency domain ?

window = signal.get_window('hanning', 64, fftbins=False) and window = np.hanning(64) ,

These both output a symmetric window for filter design.

mchitre commented 5 years ago

They produce slightly different windows without the fftbins=False flag. With that flag, they should be identical. Anyway, this has already been fixed in arlpy and so closing the issue.