org-arl / arlpy

ARL Python Tools
BSD 3-Clause "New" or "Revised" License
119 stars 37 forks source link

uwapm: Error if last depth point of the SSP does not coincide exactly with the maximum depth in the bathymetry #40

Closed harivnkochi closed 4 years ago

harivnkochi commented 4 years ago

The modeling throws an error if the last depth point of the SSP does not coincide exactly with the maximum depth in the bathymetry. i.e, even if the depth specified in the SSP goes beyond the maximum depth.

This could be a fixed by interpolating the SSP to include the max. depth in the bathymetry, to suppress the error.

mchitre commented 4 years ago

Likely due to Bellhop not handling this, in which case, arlpy can't do anything about it. But will cross check and confirm.

harivnkochi commented 4 years ago

It is indeed a Bellhop issue. Quoting the Bellhop user manual here: “The last value in SSP must correspond to the max water depth.” Snipper from Bellhop user manual below:

Snippet from Bellhop user manual

mchitre commented 4 years ago

In which case, not much to be done. Thanks.