search

org-arl / arlpy

ARL Python Tools
BSD 3-Clause "New" or "Revised" License
118 stars 37 forks source link

update subprocess call #78

Closed IvanaEscobar closed 1 year ago

IvanaEscobar commented 1 year ago

Subprocess management recommends using the run over call

The recommended approach to invoking subprocesses is to use the run() function for all use cases it can handle.

the call function was producing error in my Linux environment, can provide details upon request.

IvanaEscobar commented 1 year ago

@mchitre The code now reflects no relative paths to the BELLHOP executable, bellhop.exe

mchitre commented 1 year ago

Does this PR break compatibility with Python 3.6?

IvanaEscobar commented 1 year ago

I tested on a Python 3.6 environment and ran into no problems. I attached the conda environment and version used to test arlpy3.6.txt conda-info.txt

I also compared with the current main branch and do not produce the following fatal error message when checking for a working bellhop.exe executable, which is the current behavior

> pm.models()
   Running Bellhop...
   ['bellhop']
   STOP Fatal Error: Check the print file for details
mchitre commented 1 year ago

Sounds good. We seem to have some merge conflicts to be resolved before we can merge this.

IvanaEscobar commented 1 year ago

I see "This branch has no conflicts with the base branch",

Can you provide more information on which conflicts need to be resolved?

mchitre commented 1 year ago

Merged. Thanks for the contribution @IvanaEscobar