search

org-arl / arlpy

ARL Python Tools
BSD 3-Clause "New" or "Revised" License
119 stars 37 forks source link

Max depth of acoustic domain #82

Closed IvanaEscobar closed 1 year ago

IvanaEscobar commented 1 year ago

Current behavior:

When providing a sound speed profile as a pandas DetaFrame, and a bathymetry as a list. The environment file created takes the maximum bathymetric depth as the depth of the acoustic domain. Sometimes the sound speed profile is specified at depths deeper than the bathymetry which leads to the SSPFile not initiating properly:

At line 879 of file sspMod.f90 (unit=5, file='tmp.env')
Fortran runtime error: Bad al number in item 1 of list input

Change: Allows for the SSPFile to have a deeper value than max_depth defined by only the BTYFile. Fixing the error of current behavior.

mchitre commented 1 year ago

Sounds like a good plan @IvanaEscobar, but branch needs to be rebased.

IvanaEscobar commented 1 year ago

@mchitre Rebased! This was my first time rebasing a branch, so there were a few hiccups, but the code is updated successfully with the appropriate rebase

mchitre commented 1 year ago

Thanks @IvanaEscobar, merged!