search

org-arl / arlpy

ARL Python Tools
BSD 3-Clause "New" or "Revised" License
119 stars 37 forks source link

Fixes #89 #93

Closed patel999jay closed 11 months ago

patel999jay commented 11 months ago

Fixes arrival amplitude calculations

mchitre commented 11 months ago

Would it make sense to check if it's a tuple before extracting the entry? That will allow the same code to work on older and newer versions of Bellhop perhaps?

patel999jay commented 11 months ago

Which versions should we verify? I currently possess binaries for 2019, 2020, and 2023 versions. I suspect there may be older versions, possibly from 2016. Do you happen to have the binary for that year? I intend to conduct compatibility checks across all these versions.

mchitre commented 11 months ago

That's fantastic if you can check across these versions. I think it's sufficient to support these ones, and not bother going much further in history.

patel999jay commented 11 months ago

Compatibility Testing

I've thoroughly tested this code against multiple versions of Bellhop, including 2016, 2019, 2020, and 2023. The code has been updated to ensure compatibility with these versions, and I've confirmed that it functions as expected without any issues. I've also documented the results in a test notebook PDF, which I attach for further review.

This ensures that the fix not only resolves the issue at hand but also maintains compatibility across a range of Bellhop versions.

Please feel free to reach out if you have any additional questions or need more information regarding the compatibility testing.

Test1-2016_exe - Jupyter Notebook.pdf Test3-2019_exe - Jupyter Notebook.pdf Test4-2020_exe - Jupyter Notebook.pdf Test5-2023_exe - Jupyter Notebook.pdf

mchitre commented 11 months ago

Released 1.8.4 with this in it.