org-arl / arlpy

ARL Python Tools
BSD 3-Clause "New" or "Revised" License
118 stars 37 forks source link

Fix bellhop detection #99

Closed philipbl closed 4 months ago

philipbl commented 4 months ago

There was a problem where Bellhop was not correctly detected in the _bellhop function. More specifically, it shows up as a possible model even if it is not on the path. To reproduce, ensure Bellhop is not in your path and then run uwapm.models(). Bellhop appears in the list even though it is not on the path. Here is a demonstration:

Screenshot 2024-02-22 at 9 12 40 AM

The problem is that the return code of the subprocess command needs to be checked. I added code to check the return code and added a test.