org-arl / fjage

Framework for Java and Groovy Agents
https://fjage.readthedocs.io/en/latest/
Other
26 stars 13 forks source link

`ps` implicitly assumes all agents respond to `ParameterReq` #230

Closed mchitre closed 3 years ago

mchitre commented 3 years ago

Recently introduced class names for remote agents implicitly assumes all agents respond to ParameterReq for parameter type. This is a poor assumption and should be removed.

Suggested fix:

mchitre commented 3 years ago

Fixed.

Currently adds a [R] tag at the end of the ps entry for remote agents. Example:

unity: org.arl.unet.diversity.Unity
mac: org.arl.unet.mac.CSMA
bb: org.arl.unet.bb.Baseband [R]
phy: org.arl.unet.phy.Physical [R]

Other possible styles:

VERBOSE:

unity: org.arl.unet.diversity.Unity
mac: org.arl.unet.mac.CSMA
bb: org.arl.unet.bb.Baseband [REMOTE]
phy: org.arl.unet.phy.Physical [REMOTE]

DISCRETE:

unity: org.arl.unet.diversity.Unity
mac: org.arl.unet.mac.CSMA
bb: org.arl.unet.bb.Baseband*
phy: org.arl.unet.phy.Physical*

@notthetup Preferences? Alternative suggestions?

notthetup commented 3 years ago

Ooops. I prefer the VERBOSE style.

mchitre commented 3 years ago

Changed to [REMOTE]