org-arl / fjage

Framework for Java and Groovy Agents
https://fjage.readthedocs.io/en/latest/
Other
26 stars 13 forks source link

Fix Gateway <-> Wormhole interop #294

Closed ettersi closed 1 year ago

ettersi commented 1 year ago

Consider a setup where a Java Gateway is connected to a master container with a Unet Wormhole agent running in it. In this scenario, the gateway will currently not receive any messages addressed to it.

The technical reasons behind this are as follows.

This PR fixes both of these aspects.

Strictly speaking, either change would have been enough on its own, but there's no reason not to fix both for extra robustness (and performance in the case of the wantsMessagesFor).

notthetup commented 1 year ago

Do we need to update the other language Gateways? And maybe update the Gateway spec?

mchitre commented 1 year ago

Good question. Need to check the naming of the gateways from other languages.

ettersi commented 1 year ago

@mchitre Any chance we can make a release with this change? ST needs this for Aquarius, and making a release is probably the cleanest way to ship this code to them.

mchitre commented 1 year ago

Yes, let me try to do that sometime today

mchitre commented 1 year ago

Released fjage-1.12.1

ettersi commented 1 year ago

Do we need to update the other language Gateways? And maybe update the Gateway spec?

JS, Python and Julia gateways are fine. I've fixed the C gateway in https://github.com/org-arl/fjage/pull/295.