search

org-arl / unet-blog

Unet project blog
http://blog.unetstack.net
MIT License
1 stars 2 forks source link

A Step-by-Step Guide to Deploying and Operating an Acoustic Modem running UnetStack to Achieve the Best Performance #71

Closed manuignatius closed 1 year ago

manuignatius commented 1 year ago

Blog: https://github.com/org-arl/unet-blog/blob/demo/_posts/2023-04-03-A-Step-by-Step-Guide-to-Deploying-and-Operating-an-Acoustic-Modem-running-UnetStack-to-Achieve-the-Best-Performance.md

manuignatius commented 1 year ago

Overall good, but a few things to address:

  • [x] You're missing YAML headers.
  • [x] There's a lot of mention of gen3 and gen4 modems. Is this a UnetStack blog or a Subnero modem blog? Decide and be consistent. If you use gen3/gen4 tags, decide on capitalization and naming and be consistent. There's also mention of gen3 modems with UnetStack 4 (speedtest loaded by default) -- which is obviously incorrect. Fix.
  • [x] You may want to have file transfer before (and after) tuning the link. Otherwise it gives the feel that there are many many steps involved before you can transfer a file.
  • [x] You may want to mention expectation of 50% link rate for speedtest before you show the numbers, so that the first impression is not "oh, so low?"

Addressed all comments. For the second comment, since we have backported speedtest to UnetStack 3.x and did a release, I assumed that it is going to be standard on the latest UnetStack v3 release onwards. Removed all references to gen3/4 modems as they are redundant.