Feat/s3 public access block

org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).

MIT License

88 stars 21 forks source link

Feat/s3 public access block #12

Closed OlafConijn closed 4 years ago

OlafConijn commented 4 years ago

what do you think about:

./src/common.ts?
behavior on delete. regardless of what what was configured before it will be set to all false.... does that make sense?

eduardomourar commented 4 years ago

i have tested multiple scenarios (with and without pre-existing resource) using the resource itself based on the example and everything is working as expected:

create
update (single or multiple properties)
delete

we are able to start managing the resource even if they are already there (just like we discussed)