org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
85 stars 21 forks source link

retry create and update upon A conflicting modification in place #124

Closed rene84 closed 1 year ago

rene84 commented 1 year ago

The resource Community::Route53::VPCAssociationAuthorization uses the underlying API createVPCAssociationAuthorization. This API will throw an InternalFailure error when there is already another authorization being made.

We encountered this when we wanted to authorize multiple VPCs at once for the same hosted zone. This is actually a retryable error with the message:

failed because Resource handler returned message: "A conflicting modification to the authorizations in place for xxxxx occurred. Please retry." (RequestToken: xxxxxxx-f3d1-7270-0695-xxxxxx, HandlerErrorCode: InternalFailure).

This change will make the create and update handler return a ProgressEvent status InProgress so CloudFormation will simply call again later to retry.