search

org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
85 stars 21 forks source link

Community::SSO::AssignmentGroup needs version number bump #140

Open jim-barber-he opened 5 months ago

jim-barber-he commented 5 months ago

This Pull Request shows that the code for Community::SSO::AssignmentGroup was updated to upgrade it from node 14 to node 20. https://github.com/org-formation/aws-resource-providers/pull/139

However the sso/assignment-group/package.json file wasn't updated to bump the version number so it is still on version 0.3.1 The other providers I use had a version bump to 1.0.0 in their package.json files in the same pull request and they all upgraded okay. But without a bump to the version for the SSO assignment group provider, org-formation can't tell there was a change to deploy it.

AWS has stated the following:

Extensions using Node.js 14 and Python 3.7 cannot be registered in additional regions or accounts starting January 9, 2024. You can continue to publish updates to the existing extension until February 8, 2024, at which time you will no longer be able to update the extension without first updating to a supported runtime.

The Feb 8th date is fast approaching and I was hoping to have this provider upgraded before then.

OlafConijn commented 5 months ago

updated the specific provider to have version: 1.0.0 in its package JSON. in my expectation the package would have been updated regardless of this version number.

Is there something in specific that made you believe it did not update when updating the URL to the package? or just seemed the right thing to doL have the package version bumped to reflect the change.

I am asking out of curiosity, no more.

jim-barber-he commented 5 months ago

Is there something in specific that made you believe it did not update when updating the URL to the package?

I didn't change the URL to the package because it doesn't change if the version number hasn't changed does it? It remained as s3://community-resource-provider-catalog/community-sso-assignmentgroup-0.3.1.zip

When I bumped the versions of my other providers, the relevant part of the pipeline looked as follows:

INFO: Executing: include tasks/register-types/tasks.yml.
INFO: Executing: register-type Community_Organizations_EbsEncryptionDefaults.
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 812539610374/us-east-1 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 530261158904/us-east-1 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 868547972086/us-east-1 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 530261158904/ap-southeast-4 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 868547972086/ap-southeast-4 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 868547972086/ap-southeast-2 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 812539610374/ap-southeast-2 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 812539610374/ap-southeast-4 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 630483102483/ap-southeast-2 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 530261158904/ap-southeast-2 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 340978087534/us-east-1 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 282607948037/ap-southeast-4 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 630483102483/ap-southeast-4 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 949042831883/ap-southeast-2 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 340978087534/ap-southeast-2 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 630483102483/us-east-1 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 949042831883/us-east-1 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 340978087534/ap-southeast-4 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 949042831883/ap-southeast-4 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 282607948037/ap-southeast-2 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 759931498410/us-east-1 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 358150449161/us-east-1 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 358150449161/ap-southeast-4 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 759931498410/ap-southeast-4 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 950931304622/us-east-1 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 950931304622/ap-southeast-4 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 282607948037/us-east-1 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 950931304622/ap-southeast-2 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 759931498410/ap-southeast-2 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 358150449161/ap-southeast-2 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 197883907952/us-east-1 update successful. (197883907952 = ManagementAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 197883907952/ap-southeast-4 update successful. (197883907952 = ManagementAccount)
INFO: Workload Community_Organizations_EbsEncryptionDefaults in 197883907952/ap-southeast-2 update successful. (197883907952 = ManagementAccount)
INFO: Task Community_Organizations_EbsEncryptionDefaults execute successful.
INFO: Executing: register-type Community_Organizations_NoDefaultVPC.
INFO: Workload Community_Organizations_NoDefaultVPC in 530261158904/us-east-1 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 530261158904/ap-southeast-4 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 812539610374/us-east-1 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 868547972086/us-east-1 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 812539610374/ap-southeast-4 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 530261158904/ap-southeast-2 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 868547972086/ap-southeast-4 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 868547972086/ap-southeast-2 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 812539610374/ap-southeast-2 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 630483102483/ap-southeast-2 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 949042831883/us-east-1 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 282607948037/ap-southeast-2 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 949042831883/ap-southeast-4 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 630483102483/us-east-1 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 340978087534/us-east-1 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 949042831883/ap-southeast-2 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 340978087534/ap-southeast-4 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 282607948037/ap-southeast-4 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 340978087534/ap-southeast-2 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 630483102483/ap-southeast-4 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 282607948037/us-east-1 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 358150449161/us-east-1 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 759931498410/us-east-1 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 759931498410/ap-southeast-4 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 950931304622/ap-southeast-4 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 950931304622/us-east-1 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 759931498410/ap-southeast-2 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 358150449161/ap-southeast-4 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 950931304622/ap-southeast-2 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 358150449161/ap-southeast-2 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 197883907952/us-east-1 update successful. (197883907952 = ManagementAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 197883907952/ap-southeast-4 update successful. (197883907952 = ManagementAccount)
INFO: Workload Community_Organizations_NoDefaultVPC in 197883907952/ap-southeast-2 update successful. (197883907952 = ManagementAccount)
INFO: Task Community_Organizations_NoDefaultVPC execute successful.
INFO: Executing: register-type Community_S3_PublicAccessBlock.
INFO: Workload Community_S3_PublicAccessBlock in 812539610374/us-east-1 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_S3_PublicAccessBlock in 868547972086/ap-southeast-4 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_S3_PublicAccessBlock in 530261158904/ap-southeast-4 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_S3_PublicAccessBlock in 868547972086/us-east-1 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_S3_PublicAccessBlock in 812539610374/ap-southeast-2 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_S3_PublicAccessBlock in 812539610374/ap-southeast-4 update successful. (812539610374 = AnalyticsAccount)
INFO: Workload Community_S3_PublicAccessBlock in 530261158904/ap-southeast-2 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_S3_PublicAccessBlock in 868547972086/ap-southeast-2 update successful. (868547972086 = CallCentreAccount)
INFO: Workload Community_S3_PublicAccessBlock in 630483102483/ap-southeast-2 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_S3_PublicAccessBlock in 530261158904/us-east-1 update successful. (530261158904 = Dev-healthengineAccount)
INFO: Workload Community_S3_PublicAccessBlock in 949042831883/us-east-1 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_S3_PublicAccessBlock in 340978087534/us-east-1 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_S3_PublicAccessBlock in 630483102483/us-east-1 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_S3_PublicAccessBlock in 630483102483/ap-southeast-4 update successful. (630483102483 = FreddyHollowAccount)
INFO: Workload Community_S3_PublicAccessBlock in 340978087534/ap-southeast-4 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_S3_PublicAccessBlock in 282607948037/ap-southeast-2 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_S3_PublicAccessBlock in 282607948037/ap-southeast-4 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_S3_PublicAccessBlock in 949042831883/ap-southeast-2 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_S3_PublicAccessBlock in 340978087534/ap-southeast-2 update successful. (340978087534 = HealthEngineAccount)
INFO: Workload Community_S3_PublicAccessBlock in 949042831883/ap-southeast-4 update successful. (949042831883 = HealthEngineBackupsAccount)
INFO: Workload Community_S3_PublicAccessBlock in 759931498410/ap-southeast-4 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_S3_PublicAccessBlock in 950931304622/us-east-1 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_S3_PublicAccessBlock in 358150449161/us-east-1 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_S3_PublicAccessBlock in 759931498410/us-east-1 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_S3_PublicAccessBlock in 282607948037/us-east-1 update successful. (282607948037 = HealthEngineSecurityAccount)
INFO: Workload Community_S3_PublicAccessBlock in 950931304622/ap-southeast-4 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_S3_PublicAccessBlock in 358150449161/ap-southeast-4 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_S3_PublicAccessBlock in 759931498410/ap-southeast-2 update successful. (759931498410 = SharedServicesAccount)
INFO: Workload Community_S3_PublicAccessBlock in 950931304622/ap-southeast-2 update successful. (950931304622 = PatienCubeAccount)
INFO: Workload Community_S3_PublicAccessBlock in 358150449161/ap-southeast-2 update successful. (358150449161 = SharedComplianceAccount)
INFO: Workload Community_S3_PublicAccessBlock in 197883907952/ap-southeast-4 update successful. (197883907952 = ManagementAccount)
INFO: Workload Community_S3_PublicAccessBlock in 197883907952/ap-southeast-2 update successful. (197883907952 = ManagementAccount)
INFO: Workload Community_S3_PublicAccessBlock in 197883907952/us-east-1 update successful. (197883907952 = ManagementAccount)
INFO: Task Community_S3_PublicAccessBlock execute successful.
INFO: Executing: register-type Community_SSO_AssignmentGroup.
INFO: register-type workload Community_SSO_AssignmentGroup already up to date.
INFO: Task Community_SSO_AssignmentGroup execute successful.
INFO: Task RegisterTypes execute successful.

Here you see Community_Organizations_EbsEncryptionDefaults, Community_Organizations_NoDefaultVPC, and Community_S3_PublicAccessBlock being updated. However for Community_SSO_AssignmentGroup it just says:

INFO: Executing: register-type Community_SSO_AssignmentGroup.
INFO: register-type workload Community_SSO_AssignmentGroup already up to date.
INFO: Task Community_SSO_AssignmentGroup execute successful.

Then I checked if they've been updated using: aws cloudformation list-types --query 'TypeSummaries[].{TypeName:TypeName,LastUpdated:LastUpdated}' and get:

[
    {
        "TypeName": "Community::Organizations::EbsEncryptionDefaults",
        "LastUpdated": "2024-01-31T02:41:58.570000+00:00"
    },
    {
        "TypeName": "Community::Organizations::NoDefaultVPC",
        "LastUpdated": "2024-01-31T02:49:11.202000+00:00"
    },
    {
        "TypeName": "Community::S3::PublicAccessBlock",
        "LastUpdated": "2024-01-31T02:56:11.850000+00:00"
    },
    {
        "TypeName": "Community::SSO::AssignmentGroup",
        "LastUpdated": "2021-09-22T01:50:13.494000+00:00"
    }
]

So the last updated date for Community::SSO::AssignmentGroup is still in 2021 while the others were updated when the pipeline ran.

My tasks/register-types/tasks.yml file referenced above looks like the following:

Parameters:
  <<: !Include ../../parameters.yml

# Community resource type to enable EC2 EBS encryption by default
Community_Organizations_EbsEncryptionDefaults:
  MaxConcurrentTasks: 10
  OrganizationBinding:
    Account: '*'
    IncludeMasterAccount: true
    Region: !Ref allRegions
  ResourceType: Community::Organizations::EbsEncryptionDefaults
  SchemaHandlerPackage: s3://community-resource-provider-catalog/community-ec2-ebsencryptiondefaults-1.0.0.zip
  Type: register-type

# Community resource type to facilitate removing the default VPC.
Community_Organizations_NoDefaultVPC:
  MaxConcurrentTasks: 10
  OrganizationBinding:
    Account: '*'
    IncludeMasterAccount: true
    Region: !Ref allRegions
  ResourceType: Community::Organizations::NoDefaultVPC
  SchemaHandlerPackage: s3://community-resource-provider-catalog/community-organizations-nodefaultvpc-1.0.0.zip
  Type: register-type

# Community resource type to facilitate blocking public S3 access.
Community_S3_PublicAccessBlock:
  MaxConcurrentTasks: 10
  OrganizationBinding:
    Account: '*'
    IncludeMasterAccount: true
    Region: !Ref allRegions
  ResourceType: Community::S3::PublicAccessBlock
  SchemaHandlerPackage: s3://community-resource-provider-catalog/community-s3-publicaccessblock-1.0.0.zip
  Type: register-type

Community_SSO_AssignmentGroup:
  MaxConcurrentTasks: 10
  OrganizationBinding:
    Account: '*'
    IncludeMasterAccount: true
    Region: !Ref allRegions
  ResourceType: Community::SSO::AssignmentGroup
  SchemaHandlerPackage: s3://community-resource-provider-catalog/community-sso-assignmentgroup-0.3.1.zip
  Type: register-type

So I don't know if I should be doing something differently here?

Thanks for bumping the version. I'll update the line that installs it to use version 1 and I should be good to go.