search

org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
88 stars 21 forks source link

Update shared library for common AWS usage #18

Closed eduardomourar closed 3 years ago

eduardomourar commented 4 years ago

Issue #, if available:

Description of changes: Start using the shared library that includes the decorator for common AWS usage.

codecov[bot] commented 4 years ago

Codecov Report

Merging #18 into master will increase coverage by 4.31%. The diff coverage is 69.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   73.72%   78.04%   +4.31%     
==========================================
  Files           9        8       -1     
  Lines         529      460      -69     
  Branches       68       59       -9     
==========================================
- Hits          390      359      -31     
+ Misses        139      101      -38
Flag Coverage Δ
#unittests 78.04% <69.17%> (+4.31%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ec2/ebs-encryption-defaults/src/handlers.ts 22.00% <5.00%> (-28.00%) :arrow_down:
s3/public-access-block/src/handlers.ts 93.87% <93.02%> (+67.34%) :arrow_up:
iam/password-policy/src/handlers.ts 93.54% <100.00%> (-2.25%) :arrow_down:
cloud-formation/delay/src/handlers.ts 100.00% <0.00%> (+1.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 523a605...0270f83. Read the comment docs.

eduardomourar commented 4 years ago

@OlafConijn , let me know what you think of the file s3/public-access-block/src/common-decorator.ts. if you are in agreement, i will move that to the common library so that we can use in other providers.

eduardomourar commented 3 years ago

i will merge this, and we can discuss again your suggestions in the next iteration, ok?