search

org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
88 stars 21 forks source link

Use ARN whenever available #2

Closed eduardomourar closed 4 years ago

eduardomourar commented 4 years ago

https://github.com/OlafConijn/org-formation-resource-providers/blob/78613f7dd8d26180e7a065d49f8ddf6c95a041f5/org/organizationalunit/oc-org-organizationalunit.json#L20-L25

For most resources that you have the ARN as a unique identifier, you should remove ResourceId and leave the ARN as the only primary identifier.

OlafConijn commented 4 years ago

most of these resources have both an ARN and Id. Id is used in most of the organization Api's thats where i felt resourceId might come in handy. Maybe do need to rename this to Id (consistent with Api)

eduardomourar commented 4 years ago

Yes, we should align with the API as much as possible. Then, ARN has to be the primary identifier (that will be returned by Ref) and we add Id as additional identifier (that will be returned by GetAtt).