org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
88 stars 21 forks source link

feat: S3 service quota common decorator #23

Closed OlafConijn closed 3 years ago

OlafConijn commented 3 years ago

Issue #, if available:

Description of changes:

codecov[bot] commented 3 years ago

Codecov Report

Merging #23 into master will decrease coverage by 4.53%. The diff coverage is 73.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   84.27%   79.74%   -4.54%     
==========================================
  Files          10        8       -2     
  Lines         706      474     -232     
  Branches      115       62      -53     
==========================================
- Hits          595      378     -217     
+ Misses        111       96      -15     
Flag Coverage Δ
#unittests 79.74% <73.26%> (-4.54%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ec2/ebs-encryption-defaults/src/handlers.ts 22.00% <5.00%> (-52.29%) :arrow_down:
service-quotas/s3/src/handlers.ts 85.71% <83.33%> (+17.53%) :arrow_up:
s3/public-access-block/src/handlers.ts 93.87% <93.02%> (-3.75%) :arrow_down:
iam/password-policy/src/handlers.ts 93.54% <100.00%> (+0.60%) :arrow_up:
common/src/common-decorator.ts 92.30% <0.00%> (-5.07%) :arrow_down:
code-commit/repository-association/src/handlers.ts
code-commit/approval-rule-template/src/handlers.ts
iam/saml-provider/src/handlers.ts 62.90% <0.00%> (+1.49%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 862670d...3e18983. Read the comment docs.

eduardomourar commented 3 years ago

we need to rebase this against master

eduardomourar commented 3 years ago

@OlafConijn rebase done and i few improvements to the unit testing

eduardomourar commented 3 years ago

the only thing missing is updating the main readme page