Closed OlafConijn closed 1 year ago
@OlafConijn, I believe the build is failing because package-lock is not up-to-date. My advise is to just delete it and run npm run i --save
@OlafConijn, I believe the build is failing because package-lock is not up-to-date. My advise is to just delete it and run npm run i --save
euh, i guess not?!
There is a new version for both the RPDK as well as the common lib. Let me first test with another resource then we can try updating here
Merging #33 (e804992) into master (5e29efd) will increase coverage by
0.58%
. The diff coverage is90.42%
.:exclamation: Current head e804992 differs from pull request most recent head 3110406. Consider uploading reports for the commit 3110406 to get more accurate results
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 83.44% 84.03% +0.58%
==========================================
Files 18 15 -3
Lines 2634 2361 -273
Branches 396 375 -21
==========================================
- Hits 2198 1984 -214
+ Misses 436 377 -59
Flag | Coverage Δ | |
---|---|---|
unittests | 84.03% <90.42%> (+0.58%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
sso/assignment-group/src/handlers.ts | 80.00% <0.00%> (-2.49%) |
:arrow_down: |
security-hub/master/src/handlers.ts | 88.88% <88.88%> (ø) |
|
security-hub/members/src/handlers.ts | 93.75% <93.75%> (ø) |
|
ec2/ebs-encryption-defaults/src/handlers.ts | 66.66% <0.00%> (-4.59%) |
:arrow_down: |
service-quotas/cloud-formation/src/handlers.ts | 86.82% <0.00%> (-4.55%) |
:arrow_down: |
s3/public-access-block/src/handlers.ts | 92.98% <0.00%> (-4.48%) |
:arrow_down: |
code-commit/repository-association/src/handlers.ts | 81.78% <0.00%> (-4.46%) |
:arrow_down: |
service-quotas/s3/src/handlers.ts | 85.00% <0.00%> (-4.17%) |
:arrow_down: |
iam/password-policy/src/handlers.ts | 90.28% <0.00%> (-4.00%) |
:arrow_down: |
cloud-formation/delay/src/handlers.ts | 95.94% <0.00%> (-2.80%) |
:arrow_down: |
... and 11 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
As discussed with Olaf, we need to implement the delete operation by copying the behavior of the following AWS CLI commands:
Issue #, if available: #27
Description of changes: imeplements Community::SecurityHub::Master & Community::SecurityHub::Members