search

org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
88 stars 21 forks source link

fix(s3-public-access-block): removed invalid required attributes from… #37

Closed OlafConijn closed 3 years ago

OlafConijn commented 3 years ago

… schema

Issue #, if available:

Description of changes:

codecov[bot] commented 3 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          11       11           
  Lines         830      830           
  Branches      127      127           
=======================================
  Hits          693      693           
  Misses        137      137
Flag Coverage Δ
#unittests 83.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8001b21...8f8470a. Read the comment docs.

eduardomourar commented 3 years ago

If you run cfn generate, does it modify the readme?

OlafConijn commented 3 years ago

If you run cfn generate, does it modify the readme?

i think it would if the required attributes would have also been actual attributes in the schema. not just leftovers from the example.