Codecov Report

Merging #63 (d5e09e4) into master (2f48cee) will decrease coverage by 0.38%. The diff coverage is 65.30%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   85.36%   84.97%   -0.39%     
==========================================
  Files          16       17       +1     
  Lines        2500     2549      +49     
  Branches      386      391       +5     
==========================================
+ Hits         2134     2166      +32     
- Misses        366      383      +17

Flag	Coverage Δ
unittests	`84.97% <65.30%> (-0.39%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
service-quotas/dynamodb/src/handlers.ts	`65.30% <65.30%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f48cee...d5e09e4. Read the comment docs.

eduardomourar commented 3 years ago

we need to change line 32 in the cicd.yml file to: pip install --upgrade pip aws-sam-cli git+https://github.com/eduardomourar/cloudformation-cli-nodejs-plugin.git otherwise the pipeline just hangs forever

OlafConijn commented 3 years ago

we need to change line 32 in the cicd.yml file to: pip install --upgrade pip aws-sam-cli git+https://github.com/eduardomourar/cloudformation-cli-nodejs-plugin.git otherwise the pipeline just hangs forever

i think its still hanging? fix later?

eduardomourar commented 3 years ago

Yes, because I need to dig deeper into the problem

PatMyron commented 3 years ago

Issues might be because SAM pins exact requirements and insists it shouldn't be installed with pip: https://github.com/aws/aws-sam-cli/issues/1424 https://github.com/aws-cloudformation/cloudformation-cli/pull/579#discussion_r556233203

Also still think we should generalize quotas types: https://github.com/org-formation/aws-resource-providers/issues/71#issuecomment-816094451

org-formation / aws-resource-providers

feat(servicequotas): add dynamodb quotas #63

Codecov Report