org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
86 stars 21 forks source link

Resource not deleted when change Principal Id of a SSO Assignment Group #65

Open eduardomourar opened 3 years ago

eduardomourar commented 3 years ago

Whenever I modify the property PrincipalId, the assignment is created for the the new one, but the old one is not fully deleted.

This is happening inCommunity::SSO::AssignmentGroup resource type v0.3.1.

OlafConijn commented 3 years ago

might be an idea to not allow changing the PrincipalId?

eduardomourar commented 3 years ago

yes, i think it can be in the createOnlyProperties because that will trigger creating a new resource whenever you modify PrincipalId