search

org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
86 stars 21 forks source link

fix(s3-public-access-block): fixed upset handler that failed because invalid arguments #69

Closed OlafConijn closed 3 years ago

OlafConijn commented 3 years ago

Description of changes: putPublicAccessBlock failed previously because serialize() method returned things like 'ResourceId' and apparently not all values had the right type...

codecov[bot] commented 3 years ago

Codecov Report

Merging #69 (7592d08) into master (94b99dd) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   82.70%   82.74%   +0.04%     
==========================================
  Files          13       13              
  Lines        2116     2121       +5     
  Branches      342      342              
==========================================
+ Hits         1750     1755       +5     
  Misses        366      366
Flag Coverage Δ
unittests 82.74% <100.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
s3/public-access-block/src/handlers.ts 93.22% <100.00%> (+0.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94b99dd...1f1421f. Read the comment docs.