search

org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
86 stars 21 forks source link

fix(community-organizations-policy): change replacement strategy #70

Closed eduardomourar closed 2 years ago

eduardomourar commented 3 years ago

Issue #, if available: #68

Description of changes:

Fix error that happens when updating any of the target identifiers.

zaro0508 commented 3 years ago

I have tested this fix by changing a combination of targetIds (OUs & accounts). It seems to be working great. thanks!

OlafConijn commented 3 years ago

uff, i completely missed this pr when i created https://github.com/org-formation/aws-resource-providers/pull/83 maybe take a moment offline/planning to see how we can progress with this together?

eduardomourar commented 3 years ago

uff, i completely missed this pr when i created https://github.com/org-formation/aws-resource-providers/pull/83

maybe take a moment offline/planning to see how we can progress with this together?

Definitely. I am still trying to update to the newest version of the typescript library. I think now it works. Just needs further testing.

codecov[bot] commented 2 years ago

Codecov Report

Merging #70 (ffca705) into master (94b99dd) will increase coverage by 2.65%. The diff coverage is 84.14%.

:exclamation: Current head ffca705 differs from pull request most recent head 4dec915. Consider uploading reports for the commit 4dec915 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   82.70%   85.36%   +2.65%     
==========================================
  Files          13       16       +3     
  Lines        2116     2500     +384     
  Branches      342      386      +44     
==========================================
+ Hits         1750     2134     +384     
  Misses        366      366
Flag Coverage Δ
unittests 85.36% <84.14%> (+2.65%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sso/assignment-group/src/handlers.ts 82.48% <20.00%> (+1.89%) :arrow_up:
...te53/vpc-association-authorization/src/handlers.ts 72.72% <72.72%> (ø)
organizations/policy/src/handlers.ts 86.29% <74.19%> (-0.07%) :arrow_down:
security-hub/action-target/src/handlers.ts 82.55% <82.55%> (ø)
cloud-formation/delay/src/handlers.ts 98.74% <100.00%> (+2.79%) :arrow_up:
code-commit/approval-rule-template/src/handlers.ts 83.46% <100.00%> (+2.69%) :arrow_up:
code-commit/repository-association/src/handlers.ts 86.23% <100.00%> (+4.45%) :arrow_up:
common/src/common-decorator.ts 98.33% <100.00%> (+0.18%) :arrow_up:
ec2/ebs-encryption-defaults/src/handlers.ts 71.60% <100.00%> (+4.93%) :arrow_up:
ec2/no-default-vpc/src/handlers.ts 75.36% <100.00%> (+1.44%) :arrow_up:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7154fbd...4dec915. Read the comment docs.

eduardomourar commented 2 years ago

There are a few changes needed in the dependencies that will take a little bit longer than I care to admit.