org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
86 stars 21 forks source link

Community::ServiceQuotas::EC2 #71

Open zaro0508 opened 3 years ago

zaro0508 commented 3 years ago

provider to set the custom Service Quota limits for EC2 resources. e.g: to increase the maximum number of instances per AZ and region.

PatMyron commented 3 years ago

Instead of re-implementing specific Service Quota types, worth considering a generic type:

Properties:
  ServiceCode:
  QuotaCode:
  DesiredValue:
OlafConijn commented 3 years ago

the reason i initially went with a different approach was that

  1. QuotaCodes are hard to figure out
  2. not all QuotaCodes work
  3. validating against upper/lower bounds would have to be done at runtime (and those APIs are also not super easy). all more/less developer experience arguments. not having all service quotas covered is probably an even more difficult than all of the above combined so 👍

I figured generating the types of the ServiceQuota api could be a thing (good coverage / good DX). Judging from the fact that has not happened the above would be a great alternative