org-formation / aws-resource-providers

A community driven repository where you can find AWS Resource Type Providers for different purposes (including org-formation ones).
MIT License
86 stars 21 forks source link

Deprecate SAML provider resource #76

Closed eduardomourar closed 3 years ago

eduardomourar commented 3 years ago

AWS has released an official resource type for IAM SAML providers. Therefore, we should review our community resource to see if it is still needed.

zaro0508 commented 3 years ago

wow, i didn't even know about this until i saw this issue. hmm, how about we just add documentation that it's deprecated and tell people to use the officially supported ones from AWS?

eduardomourar commented 3 years ago

Yes. I just wanted to confirm that it works similarly to current resource provider from the community.

zaro0508 commented 3 years ago

I just switched from the ofn community one to the official aws one and it worked great for me. I didn't change my stack name so I did have to delete the existing CFN stack before deploying with AWS saml provider though. https://github.com/Sage-Bionetworks-IT/testitorgmgnt-infra/blob/master/org-formation/600-access/_tasks.yaml

OlafConijn commented 3 years ago

thanks @zaro0508